[all-commits] [llvm/llvm-project] e9c8f7: [LLDB][Minidump] Have Minidumps save off and prope...

[Jacob Lalonde via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e9c8f75d45ababe7f805078bbf7bda2e7425f1b7
      https://github.com/llvm/llvm-project/commit/e9c8f75d45ababe7f805078bbf7bda2e7425f1b7
  Author: Jacob Lalonde <jalalonde at fb.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M lldb/include/lldb/Target/DynamicLoader.h
    M lldb/source/Core/DynamicLoader.cpp
    M lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
    M lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
    M lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
    M lldb/source/Plugins/Process/minidump/ProcessMinidump.h
    M lldb/source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp
    M lldb/source/Target/Process.cpp
    M lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
    M lldb/test/API/functionalities/process_save_core_minidump/main.cpp

  Log Message:
  -----------
  [LLDB][Minidump] Have Minidumps save off and properly read TLS data (#109477)

This patch adds the support to `Process.cpp` to automatically save off
TLS sections, either via loading the memory region for the module, or
via reading `fs_base` via generic register. Then when Minidumps are
loaded, we now specify we want the dynamic loader to be the `POSIXDYLD`
so we can leverage the same TLS accessor code as `ProcessELFCore`. Being
able to access TLS Data is an important step for LLDB generated
minidumps to have feature parity with ELF Core dumps.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications