[all-commits] [llvm/llvm-project] 69b0b7: [lldb] Return an llvm::Error from GetFrameBaseValu...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Thu Oct 10 13:11:30 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 69b0b7e7ac3adc42df517c25ed7017b5af9be9f1
      https://github.com/llvm/llvm-project/commit/69b0b7e7ac3adc42df517c25ed7017b5af9be9f1
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M lldb/include/lldb/Target/StackFrame.h
    M lldb/source/Expression/DWARFExpression.cpp
    M lldb/source/Target/StackFrame.cpp

  Log Message:
  -----------
  [lldb] Return an llvm::Error from GetFrameBaseValue (#111882)

This fixes the following assertion: "Cannot create Expected<T> from
Error success value." The problem was that GetFrameBaseValue return
false without updating the Status argument. This patch eliminates the 
opportunity for mistakes by returning an llvm:Error.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list