[all-commits] [llvm/llvm-project] 0e9132: [lldb] Add early CMake check for 'make' tool (#111...

[Stefan Gränitz via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e913237871e8c9290e82be30be8b3484952eee0
      https://github.com/llvm/llvm-project/commit/0e913237871e8c9290e82be30be8b3484952eee0
  Author: Stefan Gränitz <stefan.graenitz at gmail.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/dotest.py
    M lldb/test/API/CMakeLists.txt
    M lldb/test/API/lit.cfg.py
    M lldb/test/API/lit.site.cfg.py.in

  Log Message:
  -----------
  [lldb] Add early CMake check for 'make' tool (#111531)

Many LLDB's dotest.py based tests require the `make` tool. If it's not found in Path, they fail with an obscure error and show up as `UNRESOLVED`. On Windows, llvm-lit takes care of MSYS based testing tools like cat, printf, etc., but `make` is not part of that. Let's catch the situation early and check for it at configuration time.

This error isn't fatal: It should fail the build, but not immediately stop the configuration process. There might be other issues further down the line that can be caught in the same buildbot run.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications