[all-commits] [llvm/llvm-project] 12ae1e: [C++20][Modules] Relax ODR check in unnamed module...

Dmitry Polukhin via All-commits all-commits at lists.llvm.org
Thu Oct 10 00:50:00 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 12ae1ea13e68657ac75d65fd62385cae5272e2cb
      https://github.com/llvm/llvm-project/commit/12ae1ea13e68657ac75d65fd62385cae5272e2cb
  Author: Dmitry Polukhin <34227995+dmpolukhin at users.noreply.github.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M clang/include/clang/AST/DeclBase.h
    M clang/include/clang/Serialization/ASTReader.h
    M clang/lib/AST/DeclBase.cpp
    A clang/test/Headers/header-unit-common-cmp-cat.cpp

  Log Message:
  -----------
  [C++20][Modules] Relax ODR check in unnamed modules (#111160)

Summary:
Option `-fskip-odr-check-in-gmf` is set by default and I think it is
what most of C++ developers want. But in header units, Clang ODR
checking is too strict, making them hard to use, as seen in the example
in the diff. This diff relaxes ODR checks for unnamed modules to match
GMF ODR checking.

Test Plan: check-clang



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list