[all-commits] [llvm/llvm-project] 9093ba: [Support] Include Support/thread.h before api impl...

Thomas Fransham via All-commits all-commits at lists.llvm.org
Wed Oct 9 21:45:50 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9093ba9f7ee58ccf62e58487a5028707a248c0b7
      https://github.com/llvm/llvm-project/commit/9093ba9f7ee58ccf62e58487a5028707a248c0b7
  Author: Thomas Fransham <tfransham at gmail.com>
  Date:   2024-10-10 (Thu, 10 Oct 2024)

  Changed paths:
    M llvm/lib/Support/Unix/Threading.inc
    M llvm/lib/Support/Windows/Threading.inc

  Log Message:
  -----------
  [Support] Include Support/thread.h before api implementations (#111175)

This header was included after the implementations to work around an
issue with FreeBSD, however, , this causes some issues when
dllexport\explicit visibility
attributes will be added to the headers on Windows, since the
definitions need to see the declarations for the attributes to apply.

This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on
windows.

---------

Co-authored-by: Tom Stellard <tstellar at redhat.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list