[all-commits] [llvm/llvm-project] 48ac84: [AMDGPU][GlobalISel] Align `selectVOP3PMadMixModsI...

Shilei Tian via All-commits all-commits at lists.llvm.org
Tue Oct 8 06:41:46 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 48ac846fbc7568b220d8fe3f796c4f26e117ab26
      https://github.com/llvm/llvm-project/commit/48ac846fbc7568b220d8fe3f796c4f26e117ab26
  Author: Shilei Tian <i at tianshilei.me>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-add-ext-mul.ll
    M llvm/test/CodeGen/AMDGPU/GlobalISel/fdiv.f16.ll
    A llvm/test/CodeGen/AMDGPU/GlobalISel/fmamix-constant-bus-violation.ll
    A llvm/test/CodeGen/AMDGPU/GlobalISel/fmamix-constant-bus-violation.mir
    A llvm/test/CodeGen/AMDGPU/GlobalISel/madmix-constant-bus-violation.ll
    A llvm/test/CodeGen/AMDGPU/GlobalISel/madmix-constant-bus-violation.mir

  Log Message:
  -----------
  [AMDGPU][GlobalISel] Align `selectVOP3PMadMixModsImpl` with the `SelectionDAG` counterpart (#110168)

The current `selectVOP3PMadMixModsImpl` can produce `V_MAD_FIX_F32`
instruction
that violates constant bus restriction, while its `SelectionDAG`
counterpart
doesn't. The culprit is in the copy stripping while the `SelectionDAG`
version
only has a bitcast stripping. This PR simply aligns the two version.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list