[all-commits] [llvm/llvm-project] 1f2c08: [clang-tools-extra] Fix add_clang_library usage (#...

[Thomas Fransham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f2c08b33b848dfdfeecdc7cee3644591407e219
      https://github.com/llvm/llvm-project/commit/1f2c08b33b848dfdfeecdc7cee3644591407e219
  Author: Thomas Fransham <tfransham at gmail.com>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M clang-tools-extra/clang-apply-replacements/CMakeLists.txt
    M clang-tools-extra/clang-change-namespace/CMakeLists.txt
    M clang-tools-extra/clang-doc/CMakeLists.txt
    M clang-tools-extra/clang-include-fixer/CMakeLists.txt
    M clang-tools-extra/clang-include-fixer/find-all-symbols/CMakeLists.txt
    M clang-tools-extra/clang-include-fixer/plugin/CMakeLists.txt
    M clang-tools-extra/clang-move/CMakeLists.txt
    M clang-tools-extra/clang-query/CMakeLists.txt
    M clang-tools-extra/clang-reorder-fields/CMakeLists.txt
    M clang-tools-extra/clang-tidy/CMakeLists.txt
    M clang-tools-extra/clang-tidy/abseil/CMakeLists.txt
    M clang-tools-extra/clang-tidy/altera/CMakeLists.txt
    M clang-tools-extra/clang-tidy/android/CMakeLists.txt
    M clang-tools-extra/clang-tidy/boost/CMakeLists.txt
    M clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
    M clang-tools-extra/clang-tidy/cert/CMakeLists.txt
    M clang-tools-extra/clang-tidy/concurrency/CMakeLists.txt
    M clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt
    M clang-tools-extra/clang-tidy/darwin/CMakeLists.txt
    M clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt
    M clang-tools-extra/clang-tidy/google/CMakeLists.txt
    M clang-tools-extra/clang-tidy/hicpp/CMakeLists.txt
    M clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt
    M clang-tools-extra/clang-tidy/llvm/CMakeLists.txt
    M clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt
    M clang-tools-extra/clang-tidy/misc/CMakeLists.txt
    M clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
    M clang-tools-extra/clang-tidy/mpi/CMakeLists.txt
    M clang-tools-extra/clang-tidy/objc/CMakeLists.txt
    M clang-tools-extra/clang-tidy/openmp/CMakeLists.txt
    M clang-tools-extra/clang-tidy/performance/CMakeLists.txt
    M clang-tools-extra/clang-tidy/plugin/CMakeLists.txt
    M clang-tools-extra/clang-tidy/portability/CMakeLists.txt
    M clang-tools-extra/clang-tidy/readability/CMakeLists.txt
    M clang-tools-extra/clang-tidy/tool/CMakeLists.txt
    M clang-tools-extra/clang-tidy/utils/CMakeLists.txt
    M clang-tools-extra/clang-tidy/zircon/CMakeLists.txt
    M clang-tools-extra/clangd/CMakeLists.txt
    M clang-tools-extra/clangd/index/remote/CMakeLists.txt
    M clang-tools-extra/clangd/index/remote/marshalling/CMakeLists.txt
    M clang-tools-extra/clangd/index/remote/unimplemented/CMakeLists.txt
    M clang-tools-extra/clangd/support/CMakeLists.txt
    M clang-tools-extra/clangd/tool/CMakeLists.txt
    M clang-tools-extra/clangd/xpc/CMakeLists.txt
    M clang-tools-extra/include-cleaner/lib/CMakeLists.txt

  Log Message:
  -----------
  [clang-tools-extra] Fix add_clang_library usage (#109321)

If a add_clang_library call doesn't specify building as static or shared
library they are implicitly added to the list static libraries that is
linked in to clang-cpp shared library here.

https://github.com/llvm/llvm-project/blob/315ba7740663208f8bc45a7e4f145dc1df79500c/clang/cmake/modules/AddClang.cmake#L107
Because the clang-tools-extra libraries targets were declared after
clang-cpp they by luck never got linked to clang-cpp.
This change is required for clang symbol visibility macros on windows to
work correctly for clang tools since we need to distinguish if a target
being built will be importing or exporting clang symbols from the
clang-cpp DLL.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications