[all-commits] [llvm/llvm-project] 523696: [mlir][debuginfo] Add support for subroutine annot...

[Walter Erquinigo via All-commits]

  Branch: refs/heads/users/walter-erquinigo/annotations
  Home:   https://github.com/llvm/llvm-project
  Commit: 52369672cbeea8fbc31daaa90bad17884465ba9d
      https://github.com/llvm/llvm-project/commit/52369672cbeea8fbc31daaa90bad17884465ba9d
  Author: walter erquinigo <walter at modular.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M flang/lib/Optimizer/Transforms/AddDebugInfo.cpp
    M mlir/include/mlir-c/Dialect/LLVM.h
    M mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
    M mlir/lib/CAPI/Dialect/LLVM.cpp
    M mlir/lib/Dialect/LLVMIR/IR/LLVMAttrs.cpp
    M mlir/lib/Dialect/LLVMIR/Transforms/DIScopeForLLVMFuncOp.cpp
    M mlir/lib/Target/LLVMIR/DebugImporter.cpp
    M mlir/lib/Target/LLVMIR/DebugTranslation.cpp
    M mlir/test/CAPI/llvm.c
    M mlir/test/Dialect/LLVMIR/debuginfo.mlir
    M mlir/test/Target/LLVMIR/Import/debug-info.ll
    M mlir/test/Target/LLVMIR/llvmir-debug.mlir

  Log Message:
  -----------
  [mlir][debuginfo] Add support for subroutine annotations

LLVM already supports `DW_TAG_LLVM_annotation` entries for subroutines, but this hasn't been surfaced to the LLVM dialect.
I'm doing the minimal amount of work to support string-based annotations, which is useful for attaching metadata to
functions, which is useful for debuggers to offer features beyond basic DWARF.
As LLVM already supports this, this patch is not controversial.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications