[all-commits] [llvm/llvm-project] e0df22: [clang][Driver] Rename "FatalError" key to "Error"...

[Simon Tatham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e0df221dcf5696c6e99952ee62a3b3b689433f3b
      https://github.com/llvm/llvm-project/commit/e0df221dcf5696c6e99952ee62a3b3b689433f3b
  Author: Simon Tatham <simon.tatham at arm.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M clang/docs/Multilib.rst
    M clang/include/clang/Driver/Multilib.h
    M clang/lib/Driver/Driver.cpp
    M clang/lib/Driver/Multilib.cpp
    M clang/lib/Driver/ToolChains/BareMetal.cpp
    M clang/test/Driver/baremetal-multilib-custom-error.yaml
    M clang/unittests/Driver/MultilibTest.cpp

  Log Message:
  -----------
  [clang][Driver] Rename "FatalError" key to "Error" in multilib.yaml (#110804)

This is a late-breaking change to #105684, suggested after the
original patch was already landed.


  Commit: 5a9e93f39cc78276a12852bbc4d639689fe73d5a
      https://github.com/llvm/llvm-project/commit/5a9e93f39cc78276a12852bbc4d639689fe73d5a
  Author: Simon Tatham <simon.tatham at arm.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M clang/lib/Driver/Multilib.cpp
    M clang/lib/Driver/ToolChains/BareMetal.cpp

  Log Message:
  -----------
  [clang][Driver] Improve multilib custom error reporting (#110804)

If `multilib.yaml` reports a custom error message for some unsupported
configuration, it's not very helpful to display that error message
_first_, and then follow it up with a huge list of all the multilib
configurations that _are_ supported.

In interactive use, the list is likely to scroll the most important
message off the top of the user's window, leaving them with just a
long list of available libraries, without a visible explanation of
_why_ clang just printed that long list. Also, in general, it makes
more intuitive sense to print the message last that shows why
compilation can't continue, because that's where users are most likely
to look for the reason why something stopped.


Compare: https://github.com/llvm/llvm-project/compare/5cfc6bc22b62...5a9e93f39cc7

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications