[all-commits] [llvm/llvm-project] e20bf2: [HLSL] Replace `element_type*` handles in HLSLExte...

[Helena Kotas via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e20bf28987b74ed4f4b48f49f4506d0659c09bed
      https://github.com/llvm/llvm-project/commit/e20bf28987b74ed4f4b48f49f4506d0659c09bed
  Author: Helena Kotas <hekotas at microsoft.com>
  Date:   2024-09-29 (Sun, 29 Sep 2024)

  Changed paths:
    M clang/include/clang/AST/Type.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/Sema/HLSLExternalSemaSource.cpp
    M clang/test/AST/HLSL/RWBuffer-AST.hlsl
    M clang/test/AST/HLSL/StructuredBuffer-AST.hlsl
    M clang/test/CodeGenHLSL/buffer-array-operator.hlsl
    M clang/test/CodeGenHLSL/implicit-norecurse-attrib.hlsl
    M clang/test/ParserHLSL/hlsl_resource_handle_attrs.hlsl
    M clang/test/SemaHLSL/Types/Traits/IsIntangibleType.hlsl

  Log Message:
  -----------
  [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (#110079)

Replace `element_type*` handles in HLSLExternalSemaSource with
`__hlsl_resource_t` builtin type.

The handle used to be defined as `element_type*` which was used by the
provisional subscript operator implementation. Now that the handle is
`__hlsl_resource_t` the subscript placeholder implementation was updated
to add `element_type* e;` field to the resource struct. and return a
reference to that. This field is just a temporary workaround until the
indexing is implemented properly in llvm/llvm-project#95956, at which
point the field will be removed. This seemed like a better solution than
disabling many of the existing tests that already use the `[]` operator.
One test has to be disabled nevertheless because an error based on
interactions of const and template instantiation (potential bug that can
be investigated once indexing is implemented the right way).

Fixes #84824



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications