[all-commits] [llvm/llvm-project] d48777: [mlir][polynomial] remove incorrect canonicalizati...

[Hongren Zheng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d48777ece50c39df553ed779d0771bc9ef6747cf
      https://github.com/llvm/llvm-project/commit/d48777ece50c39df553ed779d0771bc9ef6747cf
  Author: Hongren Zheng <i at zenithal.me>
  Date:   2024-09-28 (Sat, 28 Sep 2024)

  Changed paths:
    M mlir/lib/Dialect/Polynomial/IR/PolynomialCanonicalization.td
    M mlir/lib/Dialect/Polynomial/IR/PolynomialOps.cpp
    M mlir/test/Dialect/Polynomial/canonicalization.mlir

  Log Message:
  -----------
  [mlir][polynomial] remove incorrect canonicalization rule (#110318)

arith.add for tensor does not mod coefficientModulus, and it may
overflow; the result could be incorrect

It should be rewritten as modular arithmetic instead of arith

Revert https://github.com/llvm/llvm-project/pull/93132
Addresses https://github.com/google/heir/issues/749

Cc @j2kun



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications