[all-commits] [llvm/llvm-project] 4e5ee8: [AMDGPU][GlobalISel] Make `selectVOP3PMadMixModsIm...

Shilei Tian via All-commits all-commits at lists.llvm.org
Thu Sep 26 13:45:41 PDT 2024


  Branch: refs/heads/users/shiltian/fmad_mix-constant-bus-violation
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e5ee8a5c59fdee13570064601e70a3b7f80bacb
      https://github.com/llvm/llvm-project/commit/4e5ee8a5c59fdee13570064601e70a3b7f80bacb
  Author: Shilei Tian <shilei.tian at amd.com>
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-add-ext-mul.ll
    M llvm/test/CodeGen/AMDGPU/GlobalISel/fdiv.f16.ll
    A llvm/test/CodeGen/AMDGPU/GlobalISel/madmix-constant-bus-violation.mir

  Log Message:
  -----------
  [AMDGPU][GlobalISel] Make `selectVOP3PMadMixModsImpl` same as the SelectionDAG counterpart

The current `selectVOP3PMadMixModsImpl` can produce `V_MAD_FIX_F32` instruction
that violates constant bus restriction, while its `SelectionDAG` counterpart
doesn't. The culprit is in the copy stripping while the SelectionDAG version
only has a bitcast stripping. This PR simply aligns the two version.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list