[all-commits] [llvm/llvm-project] 9c48a0: [mlir][tensor] Refine the semantics of `createPadH...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9c48a04328f1dfa739985f64b33f20b67e085277
      https://github.com/llvm/llvm-project/commit/9c48a04328f1dfa739985f64b33f20b67e085277
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/Tensor/Utils/Utils.h
    M mlir/lib/Dialect/Tensor/Utils/Utils.cpp

  Log Message:
  -----------
  [mlir][tensor] Refine the semantics of `createPadHighOp` (#109667)

Refine `createPadHighOp` so that the output tensor is required to be
statically shaped. This is to prevent the current behaviour, which is
incorrect:

>  // If `type` has dynamic dimensions the padding width is set to zero.

The actual padding width should be set to: `%new_dim - %old_dim`, where
%new_dim` and `%old_dim` are defined via e.g. `tensor.dim` Op applied to
output and input tensors, respectively.

This PR is an attempt to clarify the semantics surrounding dynamic
shapes in preparation for adding support for scalable vectors to the
pack/unpack logic in Tensor/Linalg (dynamic shapes is what we use to
model scalable (*) sizes at the Tensor/MemRef level).

(*) Scalable as in Arm's Scalable Vector Extension (SVE)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications