[all-commits] [llvm/llvm-project] e7569b: [clang] [Modules] Don't assume an overriden module...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e7569b30861cce7064fdc7b0e3ad1ee80fbc1fa7
      https://github.com/llvm/llvm-project/commit/e7569b30861cce7064fdc7b0e3ad1ee80fbc1fa7
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2024-09-26 (Thu, 26 Sep 2024)

  Changed paths:
    M clang/include/clang/Serialization/ModuleFile.h

  Log Message:
  -----------
  [clang] [Modules] Don't assume an overriden module file can not be out-of-date

There is an assertion in ModuleFile assumes that an overriden module
file can't be out of date. But it is not seriously true in the case
clangd. e.g., the source files are overriden, but clangd relies on if
the files are out of date to trigger rebuilding preamble.

And techniquely, overriden doesn't imply it can't be out of date. This
was found during the use clangd of a large code base with modules.
Although I failed to reproduce an example, I feel it is fine to land
this directly for this particular case.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications