[all-commits] [llvm/llvm-project] 26e0b5: [lldb][lldb-dap] Fix compilation error on 32 bit p...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26e0b5077236064d9ab0548e049dffce4d476c06
      https://github.com/llvm/llvm-project/commit/26e0b5077236064d9ab0548e049dffce4d476c06
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M lldb/tools/lldb-dap/lldb-dap.cpp

  Log Message:
  -----------
  [lldb][lldb-dap] Fix compilation error on 32 bit platforms

https://github.com/llvm/llvm-project/pull/109485 tried to std::min
between size_t and uint64_t. size_t on 32 bit is 32 bits.

https://lab.llvm.org/buildbot/#/builders/18/builds/4430/steps/4/logs/stdio

Explicitly select the size_t template to fix this.

This will truncate one of the arguments but that's the count_requested.
If you're debugging from a 32 bit host and you asked it to read
> 32 bit range of memory from a 64 bit target, you weren't going
to have any success anyway.

The final result needs to be size_t to resize the vector with.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications