[all-commits] [llvm/llvm-project] 786dc5: [lldb-dap] Simplify `readMemory` (#109485)

[Adrian Vogelsgesang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 786dc5a2da9bb55d98c65d018de25d9bd31485ff
      https://github.com/llvm/llvm-project/commit/786dc5a2da9bb55d98c65d018de25d9bd31485ff
  Author: Adrian Vogelsgesang <avogelsgesang at salesforce.com>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py
    M lldb/tools/lldb-dap/lldb-dap.cpp

  Log Message:
  -----------
  [lldb-dap] Simplify `readMemory` (#109485)

The `readMemory` request used the `MemoryRegionInfo` so it could also
support short reads. Since #106532, this is no longer necessary, as
mentioned by @labath in a comment on #104317.

With this commit, we no longer set the `unreadableBytes` in the result.
But this is optional, anyway, according to the spec, and afaik the
VS Code UI does not make good use of `unreadableBytes`, anyway.

We prefer `SBTarget::ReadMemory` over `SBProcess::ReadMemory`, because
the `memory read` command also reads memory through the target instead
of the process, and because users would expect the UI view and the
results from memory read to be in-sync.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications