[all-commits] [llvm/llvm-project] e67bd4: [mlir][Transforms] Dialect conversion: Unify mater...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/bbarg_opresult_mat
  Home:   https://github.com/llvm/llvm-project
  Commit: e67bd4e54c8fc3ca00d1ac0975c70886fd094823
      https://github.com/llvm/llvm-project/commit/e67bd4e54c8fc3ca00d1ac0975c70886fd094823
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-09-21 (Sat, 21 Sep 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms] Dialect conversion: Unify materialization of value replacements

PR #106760 aligned the handling of dropped block arguments and dropped op results. The two helper functions that insert source materializations for uses of replaced block arguments / op results that survived the conversion are now almost identical (`legalizeConvertedArgumentTypes` and `legalizeConvertedOpResultTypes`). This PR merges the two functions and moves the implementation directly into `finalize`.

This PR simplifies the code base and improves the efficiency a bit: previously, `finalize` iterates over `ConversionPatternRewriterImpl::rewrites` twice. Now, only one iteration is needed.


  Commit: 0a06737c45740e46f73d32e06bed12dc6d17cccc
      https://github.com/llvm/llvm-project/commit/0a06737c45740e46f73d32e06bed12dc6d17cccc
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-09-21 (Sat, 21 Sep 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  Update mlir/lib/Transforms/Utils/DialectConversion.cpp

Co-authored-by: Jakub Kuderski <jakub at nod-labs.com>


Compare: https://github.com/llvm/llvm-project/compare/c3d664a2b7b1...0a06737c4574

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications