[all-commits] [llvm/llvm-project] b84d77: [Parallel] Revert sequential task changes

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b84d773fd004ce719da69fbae5ec1dbc2b951230
      https://github.com/llvm/llvm-project/commit/b84d773fd004ce719da69fbae5ec1dbc2b951230
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
    M lld/ELF/Relocations.cpp
    M llvm/include/llvm/Support/Parallel.h
    M llvm/lib/Support/Parallel.cpp
    M llvm/unittests/Support/ParallelTest.cpp

  Log Message:
  -----------
  [Parallel] Revert sequential task changes

https://reviews.llvm.org/D148728 introduced `bool Sequential` to unify
`execute` and the old `spawn` without argument. However, sequential
tasks might be executed by any worker thread (non-deterministic),
leading to non-determinism output for ld.lld -z nocombreloc (see
https://reviews.llvm.org/D133003).

In addition, the extra member variables have overhead.
This sequential task has only been used for lld parallel relocation
scanning.

This patch restores the behavior before https://reviews.llvm.org/D148728 .

Fix #105958

Pull Request: https://github.com/llvm/llvm-project/pull/109084



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications