[all-commits] [llvm/llvm-project] a9352a: [Inliner] Fix bug where attributes are propagated ...

[goldsteinn via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a9352a0d31862c15146ca863bde165498e9a80e8
      https://github.com/llvm/llvm-project/commit/a9352a0d31862c15146ca863bde165498e9a80e8
  Author: goldsteinn <35538541+goldsteinn at users.noreply.github.com>
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
    M llvm/lib/Transforms/Utils/InlineFunction.cpp
    M llvm/test/Transforms/Inline/access-attributes-prop.ll
    M llvm/test/Transforms/Inline/ret_attr_align_and_noundef.ll

  Log Message:
  -----------
  [Inliner] Fix bug where attributes are propagated incorrectly (#109347)

- **[Inliner] Add tests for incorrect propagation of return attrs; NFC**
- **[Inliner] Fix bug where attributes are propagated incorrectly**

The bug stems from the fact that we assume the new (inlined) callsite
is calling the same function as the original (callee) callsite. While
this is typically the case, since `VMap` simplifies the new
instructions, callee intrinsics callsites can end up not corresponding
with the same function.

This can lead to buggy propagation.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications