[all-commits] [llvm/llvm-project] 57b12e: [clangd] Improve robustness when clang-tidy check ...

Haojian Wu via All-commits all-commits at lists.llvm.org
Fri Sep 20 06:55:01 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57b12e8fbc9bb29ebe8f9d2a0f2c5085b38c2454
      https://github.com/llvm/llvm-project/commit/57b12e8fbc9bb29ebe8f9d2a0f2c5085b38c2454
  Author: Haojian Wu <hokein.wu at gmail.com>
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
    M clang-tools-extra/clangd/ParsedAST.cpp
    M clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

  Log Message:
  -----------
  [clangd] Improve robustness when clang-tidy check names contain leading spaces. (#109421)

The current logic assumes that check names do not have leading spaces.

In cases like "-*, clang-diagnostic*", when processing the second check
" clang-diagnostics-*" (with a leading space), the check fails on
`CDPrefix.starts_with(Check)`, resulting in all diagnostics remaining
disabled.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list