[all-commits] [llvm/llvm-project] 959448: [Transforms][IPO] Add func suffix in ArgumentPromo...

yonghong-song via All-commits all-commits at lists.llvm.org
Thu Sep 19 01:22:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 959448fbd6bc6f74fb3f9655b1387d0e8a272ab8
      https://github.com/llvm/llvm-project/commit/959448fbd6bc6f74fb3f9655b1387d0e8a272ab8
  Author: yonghong-song <yhs at fb.com>
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
    M llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
    M llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp
    M llvm/test/Analysis/LazyCallGraph/remove-dead-function-spurious-ref-edge.ll
    M llvm/test/BugPoint/remove_arguments_test.ll
    M llvm/test/CodeGen/AArch64/arg_promotion.ll
    M llvm/test/CodeGen/AMDGPU/internalize.ll
    M llvm/test/ThinLTO/X86/memprof-aliased-location1.ll
    M llvm/test/ThinLTO/X86/memprof-aliased-location2.ll
    M llvm/test/ThinLTO/X86/memprof-basic.ll
    M llvm/test/ThinLTO/X86/memprof-duplicate-context-ids.ll
    M llvm/test/ThinLTO/X86/memprof-funcassigncloning.ll
    M llvm/test/ThinLTO/X86/memprof-indirectcall.ll
    M llvm/test/ThinLTO/X86/memprof-inlined.ll
    M llvm/test/Transforms/ArgumentPromotion/2008-02-01-ReturnAttrs.ll
    M llvm/test/Transforms/ArgumentPromotion/BPF/argpromotion.ll
    M llvm/test/Transforms/ArgumentPromotion/X86/attributes.ll
    M llvm/test/Transforms/ArgumentPromotion/X86/min-legal-vector-width.ll
    M llvm/test/Transforms/ArgumentPromotion/X86/thiscall.ll
    M llvm/test/Transforms/ArgumentPromotion/actual-arguments.ll
    M llvm/test/Transforms/ArgumentPromotion/aggregate-promote-dead-gep.ll
    M llvm/test/Transforms/ArgumentPromotion/aggregate-promote.ll
    M llvm/test/Transforms/ArgumentPromotion/align.ll
    M llvm/test/Transforms/ArgumentPromotion/allocsize.ll
    M llvm/test/Transforms/ArgumentPromotion/attrs.ll
    M llvm/test/Transforms/ArgumentPromotion/basictest.ll
    M llvm/test/Transforms/ArgumentPromotion/bitcasts.ll
    M llvm/test/Transforms/ArgumentPromotion/byval-2.ll
    M llvm/test/Transforms/ArgumentPromotion/byval-with-padding.ll
    M llvm/test/Transforms/ArgumentPromotion/byval.ll
    M llvm/test/Transforms/ArgumentPromotion/chained.ll
    M llvm/test/Transforms/ArgumentPromotion/control-flow2.ll
    M llvm/test/Transforms/ArgumentPromotion/crash.ll
    M llvm/test/Transforms/ArgumentPromotion/dbg.ll
    M llvm/test/Transforms/ArgumentPromotion/fp80.ll
    M llvm/test/Transforms/ArgumentPromotion/inalloca.ll
    M llvm/test/Transforms/ArgumentPromotion/invalidation.ll
    M llvm/test/Transforms/ArgumentPromotion/load-alignment-value-overflows-addrspace-size.ll
    M llvm/test/Transforms/ArgumentPromotion/max-elements-limit.ll
    M llvm/test/Transforms/ArgumentPromotion/metadata.ll
    M llvm/test/Transforms/ArgumentPromotion/min-legal-vector-width.ll
    M llvm/test/Transforms/ArgumentPromotion/nonzero-address-spaces.ll
    M llvm/test/Transforms/ArgumentPromotion/opaque-ptr.ll
    M llvm/test/Transforms/ArgumentPromotion/pr27568.ll
    M llvm/test/Transforms/ArgumentPromotion/pr32917.ll
    M llvm/test/Transforms/ArgumentPromotion/pr33641_remove_arg_dbgvalue.ll
    M llvm/test/Transforms/ArgumentPromotion/profile.ll
    M llvm/test/Transforms/ArgumentPromotion/propagate-remove-dead-args.ll
    M llvm/test/Transforms/ArgumentPromotion/recursion/aggregate-promote-recursive.ll
    M llvm/test/Transforms/ArgumentPromotion/recursion/argpromotion-recursion-pr1259.ll
    M llvm/test/Transforms/ArgumentPromotion/recursion/recursion-mixed-calls.ll
    M llvm/test/Transforms/ArgumentPromotion/recursion/recursion-non-zero-offset.ll
    M llvm/test/Transforms/ArgumentPromotion/reserve-tbaa.ll
    M llvm/test/Transforms/ArgumentPromotion/sret.ll
    M llvm/test/Transforms/ArgumentPromotion/store-into-inself.ll
    M llvm/test/Transforms/ArgumentPromotion/unused-argument.ll
    M llvm/test/Transforms/Attributor/reduced/clear_cached_analysis_for_deleted_functions.ll
    M llvm/test/Transforms/DeadArgElim/2007-02-07-FuncRename.ll
    M llvm/test/Transforms/DeadArgElim/2007-12-20-ParamAttrs.ll
    M llvm/test/Transforms/DeadArgElim/2010-04-30-DbgInfo.ll
    M llvm/test/Transforms/DeadArgElim/aggregates.ll
    M llvm/test/Transforms/DeadArgElim/call_profile.ll
    M llvm/test/Transforms/DeadArgElim/comdat.ll
    M llvm/test/Transforms/DeadArgElim/dbginfo-update-dbgval-local.ll
    M llvm/test/Transforms/DeadArgElim/dbginfo.ll
    M llvm/test/Transforms/DeadArgElim/deadretval.ll
    M llvm/test/Transforms/DeadArgElim/fct_ptr.ll
    M llvm/test/Transforms/DeadArgElim/func_metadata.ll
    M llvm/test/Transforms/DeadArgElim/funclet.ll
    M llvm/test/Transforms/DeadArgElim/keepalive.ll
    M llvm/test/Transforms/DeadArgElim/nonzero-address-spaces.ll
    M llvm/test/Transforms/DeadArgElim/returned.ll
    M llvm/test/Transforms/DeadArgElim/variadic_safety.ll
    M llvm/test/Transforms/FunctionSpecialization/function-specialization2.ll
    M llvm/test/Transforms/FunctionSpecialization/global-var-constants.ll
    M llvm/test/Transforms/FunctionSpecialization/non-argument-tracked.ll
    M llvm/test/Transforms/FunctionSpecialization/specialization-order.ll
    M llvm/test/Transforms/PhaseOrdering/dae-dce.ll
    M llvm/test/Transforms/PhaseOrdering/dce-after-argument-promotion.ll
    M llvm/test/Transforms/SCCP/recursion.ll

  Log Message:
  -----------
  [Transforms][IPO] Add func suffix in ArgumentPromotion and DeadArgume… (#105742)

…ntElimination

ArgumentPromotion and DeadArgumentElimination passes could change
function signatures but the function name remains the same as before the
transformation. This makes it hard for tracing with bpf programs where
user tends to use function signature in the source. See discussion [1]
for details.

This patch added suffix to functions whose signatures are changed. The
suffix lets users know that function signature has changed and they need
to impact the IR or binary to find modified signature before tracing
those functions.

The suffix for ArgumentPromotion is ".argprom" and the suffixes for
DeadArgumentElimination are ".argelim" and ".retelim". The suffix also
gives user hints about what kind of transformation has been done.

With this patch, I built a recent linux kernel with full LTO enabled. I
got 4 functions with only argpromotion like
```
  set_track_update.argelim.argprom
  pmd_trans_huge_lock.argprom
  ...
```
I got 1058 functions with only deadargelim like
```
  process_bit0.argelim
  pci_io_ecs_init.argelim
  ...
```
I got 3 functions with both argpromotion and deadargelim
```
  set_track_update.argelim.argprom
  zero_pud_populate.argelim.argprom
  zero_pmd_populate.argelim.argprom
```

  [1] https://github.com/llvm/llvm-project/issues/104678



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list