[all-commits] [llvm/llvm-project] 6ce140: [lld][WebAssembly] Report unsupported PIC relocati...

[Luc Blaeser via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6ce14099ffa1194a5ed1f1ae6c35a4e811706fae
      https://github.com/llvm/llvm-project/commit/6ce14099ffa1194a5ed1f1ae6c35a4e811706fae
  Author: Luc Blaeser <112870813+luc-blaeser at users.noreply.github.com>
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
    A lld/test/wasm/unsupported-pic-relocations.s
    A lld/test/wasm/unsupported-pic-relocations64.s
    M lld/wasm/Relocations.cpp

  Log Message:
  -----------
  [lld][WebAssembly] Report unsupported PIC relocations as errors (#104926)

`WASM_MEMORY_ADDR_REL_` and `WASM_TABLE_INDEX_REL_` relocations against
**undefined symbols** are not supported and, except for
`UnresolvedPolicy::ReportError`, lead to incorrect Wasm code, such as
invalid data address or invalid table index that cannot be patched
during later dynamic Wasm linking with modules declaring those symbols.
This is different to other relocations that support undefined symbols by
declaring correspond Wasm imports.

For more robust behavior, `wasm-ld` should probably report an error for
such unsupported PIC relocations, independent of the `UnresolvedPolicy`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications