[all-commits] [llvm/llvm-project] 620738: [lldb-dap][test] Fix `readMemory` test (#109057)

Adrian Vogelsgesang via All-commits all-commits at lists.llvm.org
Wed Sep 18 07:16:54 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 620738e66260f00f08808b3e676a697fc32db92e
      https://github.com/llvm/llvm-project/commit/620738e66260f00f08808b3e676a697fc32db92e
  Author: Adrian Vogelsgesang <avogelsgesang at salesforce.com>
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/memory/TestDAP_memory.py

  Log Message:
  -----------
  [lldb-dap][test] Fix `readMemory` test (#109057)

So far, the test case was also testing the offset -1. This test cases
failed if the string is immediately at the beginning of the memory
region, though, and the offset -1 hence belonged to a different memory
region.

The fix is rather straightforward:
Passing an offset of -1 is not used by any actual clients of lldb-dap,
anyway. As such, this commit simply removes the corresponding test case.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list