[all-commits] [llvm/llvm-project] eae507: [clang] Use canonical type for substitution which ...

[Matheus Izvekov via All-commits]

  Branch: refs/heads/users/mizvekov/clang-fix-GH18291-6
  Home:   https://github.com/llvm/llvm-project
  Commit: eae5075a033c44b32d452233628a152d0e08fec8
      https://github.com/llvm/llvm-project/commit/eae5075a033c44b32d452233628a152d0e08fec8
  Author: Matheus Izvekov <mizvekov at gmail.com>
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
    M clang/lib/Sema/SemaTemplateDeduction.cpp
    M clang/test/SemaTemplate/GH18291.cpp

  Log Message:
  -----------
  [clang] Use canonical type for substitution which might be incomplete

When checking deduction consistency, a substitution can be incomplete
such that only sugar parts refer to non-deduced template parameters.

This would not otherwise lead to an inconsistent deduction, so
this patch makes it so we canonicalize the types before substitution
in order to avoid that possibility, for now.

When we are able to produce substitution failure diagnostics for
partial ordering, we might want to improve the TemplateInstantiator
so that it does not fail in that case.

This fixes a regression on top of #100692, which was reported on
the PR. This was never released, so there are no release notes.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications