[all-commits] [llvm/llvm-project] 905de9: [HLSL] Add testing for space parameter on global ...

[Joshua Batista via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 905de9b0fe06d960e7f60175e6c96b955f334a66
      https://github.com/llvm/llvm-project/commit/905de9b0fe06d960e7f60175e6c96b955f334a66
  Author: Joshua Batista <jbatista at microsoft.com>
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaHLSL.cpp
    M clang/test/SemaHLSL/resource_binding_attr_error.hlsl
    M clang/test/SemaHLSL/resource_binding_attr_error_basic.hlsl
    A clang/test/SemaHLSL/resource_binding_attr_error_space.hlsl

  Log Message:
  -----------
  [HLSL] Add testing  for space parameter on global constants (#106782)

The space parameter in the register binding annotation may not be used
for global constants. There was previously no diagnostic emitted when
this case occurred. This PR adds a diagnostic when this case occurs, and
tests these cases.
A new file was made to specifically test the space parameter, so some
cases in `\clang\test\SemaHLSL\resource_binding_attr_error.hlsl` were
moved over to this new file.
Fixes #104521



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications