[all-commits] [llvm/llvm-project] a1d646: [MLIR][IR] Fix InProgressAliasInfo init for non-al...

[Billy Zhu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a1d64626ba16f5128530ac771c6e641b1155184f
      https://github.com/llvm/llvm-project/commit/a1d64626ba16f5128530ac771c6e641b1155184f
  Author: Billy Zhu <billyzhu at modular.com>
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/test/IR/print-attr-type-aliases.mlir

  Log Message:
  -----------
  [MLIR][IR] Fix InProgressAliasInfo init for non-alias (#109013)

When visiting an attr/type that is NoAlias, the created
`InProgressAliasInfo` was not getting its `canBeDeferred` and `isType`
fields set. Not setting `canBeDeferred` when it should be true breaks
the assumption that all nested elements are also false. This will cause
problems when at a later point the attr/type needs to be converted by
`markAliasNonDeferrable`, as recursion will stop when a
`canBeDeferred=false` attr/type is reached, leaving its nested elements
not flipped. This causes nested elements to be printed later in the
textual IR and cannot be parsed back in.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications