[all-commits] [llvm/llvm-project] 34e16b: [IndVars] Fix strict weak ordering violation (#108...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 34e16b6b9c8628e562e237aaa9a3bc2625980ca1
      https://github.com/llvm/llvm-project/commit/34e16b6b9c8628e562e237aaa9a3bc2625980ca1
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
    M llvm/lib/Transforms/Scalar/IndVarSimplify.cpp

  Log Message:
  -----------
  [IndVars] Fix strict weak ordering violation (#108947)

The sort used the block name as a tie-breaker, which will not work for
unnamed blocks and can result in a strict weak ordering violation.

Fix this by checking that all exiting blocks dominate the latch first,
which means that we have a total dominance order. This makes the code
structure here align with what optimizeLoopExits() does.

Fixes https://github.com/llvm/llvm-project/issues/108618.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications