[all-commits] [llvm/llvm-project] e6618a: [flang] fix ignore_tkr(tk) with character dummy (#...

[jeanPerier via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e6618aae43012d3759f326ac6527744885825331
      https://github.com/llvm/llvm-project/commit/e6618aae43012d3759f326ac6527744885825331
  Author: jeanPerier <jperier at nvidia.com>
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
    M flang/lib/Lower/ConvertCall.cpp
    M flang/lib/Optimizer/Builder/FIRBuilder.cpp
    A flang/test/Lower/HLFIR/ignore-type-f77-character.f90
    M flang/test/Lower/call-suspect.f90
    M flang/test/Lower/implicit-call-mismatch.f90

  Log Message:
  -----------
  [flang] fix ignore_tkr(tk) with character dummy (#108168)

The test code with ignore_tkr(tk) on character dummy passed by
fir.boxchar<> was crashing the compiler in [an
assert](https://github.com/llvm/llvm-project/blob/2afe678f0a246387977a8ca694d4489e2c868991/flang/lib/Optimizer/Dialect/FIRType.cpp#L632)
in `changeElementType`.

It makes little sense to call changeElementType on a fir.boxchar since
this type is lossy (the shape is not part of it). Just skip it in the
code dealing with ignore(tk) when hitting this case



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications