[all-commits] [llvm/llvm-project] d3cdf0: [LLVM][Option] Refactor option name comparison (#1...

[Rahul Joshi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d3cdf0f2220cb913092934d7bf08c89951d56f8d
      https://github.com/llvm/llvm-project/commit/d3cdf0f2220cb913092934d7bf08c89951d56f8d
  Author: Rahul Joshi <rjoshi at nvidia.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    A llvm/include/llvm/Support/OptionStrCmp.h
    M llvm/lib/Option/OptTable.cpp
    M llvm/lib/Option/Option.cpp
    M llvm/lib/Support/CMakeLists.txt
    A llvm/lib/Support/OptionStrCmp.cpp
    M llvm/utils/TableGen/Common/OptEmitter.cpp
    M llvm/utils/TableGen/Common/OptEmitter.h
    M llvm/utils/TableGen/OptParserEmitter.cpp
    M llvm/utils/TableGen/OptRSTEmitter.cpp

  Log Message:
  -----------
  [LLVM][Option] Refactor option name comparison (#108219)

Move common functions shared by TableGen Option Emitter
and Options library to Support:
- Move `StrCmpOptionName` and base it on the existing version
  in OptTable.cpp, with an additional mode to control fall back to
  case insensitive comparison.
- Add `StrCmpOptionPrefixes` to compare prefixes and use zip() to
  iterate through lists of prefixes.
- Rename `CompareOptionRecords` to less ambiguous name 
  `IsOptionRecordLess`.
- Merge 2 back-to-back ifs with same condition in
  `IsOptionRecordLess`.

Fixes https://github.com/llvm/llvm-project/issues/107723



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications