[all-commits] [llvm/llvm-project] 853bff: [Coroutines] properly update CallGraph in CoroSpli...

Yuxuan Chen via All-commits all-commits at lists.llvm.org
Thu Sep 12 10:45:43 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 853bff2122e1f42398587f76234c05d56f16318e
      https://github.com/llvm/llvm-project/commit/853bff2122e1f42398587f76234c05d56f16318e
  Author: Yuxuan Chen <ych at fb.com>
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
    M llvm/lib/Transforms/Coroutines/CoroSplit.cpp
    A llvm/test/Transforms/Coroutines/gh107139-split-in-scc.ll

  Log Message:
  -----------
  [Coroutines] properly update CallGraph in CoroSplit (#107935)

Fixes https://github.com/llvm/llvm-project/issues/107139.

We weren't updating the call graph properly in CoroSplit. This crash is
due to the await_suspend() function calling the coroutine, forming a
multi-node SCC. The issue bisected to
https://github.com/llvm/llvm-project/pull/79712 but I think this is red
herring. We haven't been properly updating the call graph.

Added an example of such code as a test case.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list