[all-commits] [llvm/llvm-project] 1f215a: [mlir][Transforms] Dialect conversion: Unify mater...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/bbarg_opresult_mat
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f215ac7861a76f653c9911a31bf484a5fd6dac4
      https://github.com/llvm/llvm-project/commit/1f215ac7861a76f653c9911a31bf484a5fd6dac4
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp
    M mlir/test/Conversion/VectorToSPIRV/vector-to-spirv.mlir

  Log Message:
  -----------
  [mlir][Transforms] Dialect conversion: Unify materialization of value replacements

PR #106760 aligned the handling of dropped block arguments and dropped op results. The two helper functions that insert source materializations for uses of replaced block arguments / op results that survived the conversion are now almost identical (`legalizeConvertedArgumentTypes` and `legalizeConvertedOpResultTypes`). This PR merges the two functions and moves the implementation directly into `finalize`.

This PR simplifies the code base and improves the efficiency a bit: previously, `finalize` iterates over `ConversionPatternRewriterImpl::rewrites` twice. Now, only one iteration is needed.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications