[all-commits] [llvm/llvm-project] 96b7c6: [LLDB] Reapply SBSaveCore Add Memory List (#107937)

[Jacob Lalonde via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 96b7c64b8a874584a9dad44bb8901904c14701c0
      https://github.com/llvm/llvm-project/commit/96b7c64b8a874584a9dad44bb8901904c14701c0
  Author: Jacob Lalonde <jalalonde at fb.com>
  Date:   2024-09-11 (Wed, 11 Sep 2024)

  Changed paths:
    M lldb/include/lldb/API/SBMemoryRegionInfo.h
    M lldb/include/lldb/API/SBSaveCoreOptions.h
    M lldb/include/lldb/Symbol/SaveCoreOptions.h
    A lldb/include/lldb/Target/CoreFileMemoryRanges.h
    M lldb/include/lldb/Target/Process.h
    M lldb/include/lldb/Utility/RangeMap.h
    M lldb/include/lldb/lldb-enumerations.h
    M lldb/include/lldb/lldb-forward.h
    M lldb/include/lldb/lldb-private-interfaces.h
    M lldb/source/API/SBSaveCoreOptions.cpp
    M lldb/source/Commands/CommandObjectProcess.cpp
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
    M lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
    M lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h
    M lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.h
    M lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
    M lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
    M lldb/source/Symbol/SaveCoreOptions.cpp
    M lldb/source/Target/CMakeLists.txt
    A lldb/source/Target/CoreFileMemoryRanges.cpp
    M lldb/source/Target/Process.cpp
    M lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
    M lldb/unittests/Process/Utility/CMakeLists.txt
    A lldb/unittests/Process/Utility/CoreFileMemoryRangesTest.cpp

  Log Message:
  -----------
  [LLDB] Reapply SBSaveCore Add Memory List (#107937)

Recently in #107731 this change was revereted due to excess memory size
in `TestSkinnyCore`. This was due to a bug where a range's end was being
passed as size. Creating massive memory ranges.

Additionally, and requiring additional review, I added more unit tests
and more verbose logic to the merging of save core memory regions.

@jasonmolenda as an FYI.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications