[all-commits] [llvm/llvm-project] 524a02: [MemProf] Streamline and avoid unnecessary context...

[Teresa Johnson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 524a028f69cdf25503912c396ebda7ebf0065ed2
      https://github.com/llvm/llvm-project/commit/524a028f69cdf25503912c396ebda7ebf0065ed2
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp

  Log Message:
  -----------
  [MemProf] Streamline and avoid unnecessary context id duplication (#107918)

Sort the list of calls such that those with the same stack ids are also
sorted by function. This allows processing of all matching calls (that
can share a context node) in bulk as they are all adjacent.

This has 2 benefits:
1. It reduces unnecessary work, specifically the handling to intersect
   the context ids with those along the graph edges for the stack ids,
   for calls that we know can share a node.
2. It simplifies detecting when we have matching stack ids but don't
   need to duplicate context ids. Specifically, we were previously
   still duplicating context ids whenever we saw another call with the
   same stack ids, but that isn't necessary if they will share a context
   node. With this change we now only duplicate context ids if we see
   some that not only have the same ids but also are in different
   functions.

This change reduced the amount of context id duplication and provided
reductions in both both peak memory (~8%) and time (~%5) for a large
target.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications