[all-commits] [llvm/llvm-project] 492683: [LLDB][Minidump] Support minidumps where there are...

[Jacob Lalonde via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 492683527eda7ef055660842d9a6b7e2575ae208
      https://github.com/llvm/llvm-project/commit/492683527eda7ef055660842d9a6b7e2575ae208
  Author: Jacob Lalonde <jalalonde at fb.com>
  Date:   2024-09-09 (Mon, 09 Sep 2024)

  Changed paths:
    M lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
    M lldb/source/Plugins/Process/minidump/MinidumpParser.h
    M lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
    M lldb/source/Plugins/Process/minidump/ProcessMinidump.h
    M lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
    A lldb/test/API/functionalities/postmortem/minidump-new/multiple-sigsev.yaml
    M lldb/unittests/Process/minidump/MinidumpParserTest.cpp

  Log Message:
  -----------
  [LLDB][Minidump] Support minidumps where there are multiple exception streams (#97470)

Currently, LLDB assumes all minidumps will have unique sections. This is
intuitive because almost all of the minidump sections are themselves
lists. Exceptions including Signals are unique in that they are all
individual sections with their own directory.

This means LLDB fails to load minidumps with multiple exceptions due to
them not being unique. This behavior is erroneous and this PR introduces
support for an arbitrary number of exception streams. Additionally, stop
info was calculated only for a single thread before, and now we properly
support mapping exceptions to threads.

~~This PR is starting in DRAFT because implementing testing is still
required.~~



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications