[all-commits] [llvm/llvm-project] 61ba60: [orc] Avoid pathological propogation order (#107488)

[Ben Langmuir via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 61ba60c15416db03872e94217fcc215371caad5d
      https://github.com/llvm/llvm-project/commit/61ba60c15416db03872e94217fcc215371caad5d
  Author: Ben Langmuir <blangmuir at apple.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp

  Log Message:
  -----------
  [orc] Avoid pathological propogation order (#107488)

In certain pathological object files we were getting extremely slow
linking because we were repeatedly propogating dependencies to the same
blocks instead of accumulating as many changes as possible. Change the
order of iteration so that we go through every node in the worklist
before returning to any previous node, reducing the number of expensive
dependency iterations.

In practice, this took one case from 60 seconds to 2 seconds. Note: the
performance is still non-deterministic, because the block order itself
is non-deterministic.

rdar://133734391



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications