[all-commits] [llvm/llvm-project] 8af086: AffineExpr: Fix result of d0 + (d0 // -c) * c. (#1...

[Johannes Reifferscheid via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8af0860529d75b61b66cb96ac05f503b0e2e845c
      https://github.com/llvm/llvm-project/commit/8af0860529d75b61b66cb96ac05f503b0e2e845c
  Author: Johannes Reifferscheid <jreiffers at google.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M mlir/lib/IR/AffineExpr.cpp
    M mlir/unittests/IR/AffineExprTest.cpp

  Log Message:
  -----------
  AffineExpr: Fix result of d0 + (d0 // -c) * c. (#107530)

Currently, this is rewritten to d0 mod -c. However, we do not support
modulo with a negative RHS in our lowering passes, so this triggers
undefined behavior.

It would be better to not have these ad hoc simplifications at all, but
I guess that ship has sailed.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications