[all-commits] [llvm/llvm-project] 1be9a8: [mlir][affine] Fix the crash due to the simultaneo...

[Kai Sasaki via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1be9a80768a03ea9bd2bfbb03762b2bc3c350007
      https://github.com/llvm/llvm-project/commit/1be9a80768a03ea9bd2bfbb03762b2bc3c350007
  Author: Kai Sasaki <lewuathe at gmail.com>
  Date:   2024-09-06 (Fri, 06 Sep 2024)

  Changed paths:
    M mlir/lib/Dialect/Affine/Utils/Utils.cpp
    M mlir/test/Dialect/Affine/scalrep.mlir

  Log Message:
  -----------
  [mlir][affine] Fix the crash due to the simultaneous replacement store (#90829)

`AffineScalarReplacement` should forward the memref store op to load op
only if the store op reaches the load. But it now checks the
reachability only if these ops are in the same block, which causes the
crash reported in https://github.com/llvm/llvm-project/issues/76309.

We need to check the reachability even if they are both in the same
block, which rescues the case where consecutive store operations are
written before the load op.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications