[all-commits] [llvm/llvm-project] 08533a: [Offload][NFC] Reorganize `utils::` and make Devic...

Johannes Doerfert via All-commits all-commits at lists.llvm.org
Thu Sep 5 13:36:49 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 08533a3ee8f3a09a59cf6ac3be59198b26b7f739
      https://github.com/llvm/llvm-project/commit/08533a3ee8f3a09a59cf6ac3be59198b26b7f739
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M offload/DeviceRTL/CMakeLists.txt
    M offload/DeviceRTL/include/Allocator.h
    M offload/DeviceRTL/include/Configuration.h
    A offload/DeviceRTL/include/DeviceTypes.h
    A offload/DeviceRTL/include/DeviceUtils.h
    M offload/DeviceRTL/include/Interface.h
    M offload/DeviceRTL/include/LibC.h
    M offload/DeviceRTL/include/Mapping.h
    M offload/DeviceRTL/include/State.h
    M offload/DeviceRTL/include/Synchronization.h
    R offload/DeviceRTL/include/Types.h
    R offload/DeviceRTL/include/Utils.h
    M offload/DeviceRTL/src/Allocator.cpp
    M offload/DeviceRTL/src/Configuration.cpp
    M offload/DeviceRTL/src/Debug.cpp
    A offload/DeviceRTL/src/DeviceUtils.cpp
    M offload/DeviceRTL/src/Kernel.cpp
    M offload/DeviceRTL/src/Mapping.cpp
    M offload/DeviceRTL/src/Misc.cpp
    M offload/DeviceRTL/src/Parallelism.cpp
    M offload/DeviceRTL/src/Reduction.cpp
    M offload/DeviceRTL/src/State.cpp
    M offload/DeviceRTL/src/Synchronization.cpp
    M offload/DeviceRTL/src/Tasking.cpp
    R offload/DeviceRTL/src/Utils.cpp
    M offload/DeviceRTL/src/Workshare.cpp
    A offload/include/Shared/RefCnt.h
    A offload/include/Shared/Types.h
    M offload/include/Shared/Utils.h
    M offload/plugins-nextgen/amdgpu/src/rtl.cpp
    M offload/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h
    M offload/plugins-nextgen/common/include/PluginInterface.h
    M offload/plugins-nextgen/common/src/GlobalHandler.cpp
    M offload/plugins-nextgen/common/src/JIT.cpp
    M offload/plugins-nextgen/common/src/PluginInterface.cpp
    M offload/plugins-nextgen/cuda/src/rtl.cpp
    M offload/src/DeviceImage.cpp
    M offload/src/omptarget.cpp

  Log Message:
  -----------
  [Offload][NFC] Reorganize `utils::` and make Device/Host/Shared clearer (#100280)

We had three `utils::` namespaces, all with different "meaning" (host,
device, hsa_utils). We should, when we can, keep "include/Shared"
accessible from host and device, thus RefCountTy has been moved to a
separate header. `hsa_utils` was introduced to make `utils::` less
overloaded. And common functionality was de-duplicated, e.g.,
`utils::advance` and `utils::advanceVoidPtr` -> `utils:advancePtr`. Type
punning now checks for the size of the result to make sure it matches
the source type.

No functional change was intended.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list