[all-commits] [llvm/llvm-project] 2f6e4e: [IR] Check parameters of target extension types on...

[Jay Foad via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2f6e4ed389a6589f340d7efab2b0c7ee22c3d086
      https://github.com/llvm/llvm-project/commit/2f6e4ed389a6589f340d7efab2b0c7ee22c3d086
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M llvm/include/llvm/IR/DerivedTypes.h
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    M llvm/lib/IR/Type.cpp
    A llvm/test/Assembler/target-type-param-errors.ll

  Log Message:
  -----------
  [IR] Check parameters of target extension types on construction (#107268)

Since IR Types are immutable it makes sense to check them on
construction instead of in the IR Verifier pass.

This patch checks that some TargetExtTypes are well-formed in the sense
that they have the expected number of type parameters and integer
parameters. When called from LLParser it gives a diagnostic message.
When called from anywhere else it just asserts that they are
well-formed.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications