[all-commits] [llvm/llvm-project] 0c8d6d: Fix handling of FP-classify where the last arg fai...

[Erich Keane via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c8d6df362fe5b4bce54776e2199623d0382293b
      https://github.com/llvm/llvm-project/commit/0c8d6df362fe5b4bce54776e2199623d0382293b
  Author: erichkeane <ekeane at nvidia.com>
  Date:   2024-09-05 (Thu, 05 Sep 2024)

  Changed paths:
    M clang/lib/Sema/SemaChecking.cpp
    M clang/test/Sema/builtin-unary-fp.c

  Log Message:
  -----------
  Fix handling of FP-classify where the last arg fails to convert

The last argument of an FP-classify function was checked for vailidity
as an expression, but we never ensured that the usual unary
conversions/etc properly resulted in a valid value. Thus, when we got
the value, it was null, so we had a null dereference.

This patch instead fails out/marks the function call as invalid if the
argument is incorrect.  I DID consider just allowing it to continue, but
the result was an extraneous error about how the last argument wasn't a
float (in this case, it was an overload set).

Fixes: #107411



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications