[all-commits] [llvm/llvm-project] 7c4eb6: [Clang] Fix CLANG_TOOLCHAIN_PROGRAM_TIMEOUT logic

Joel E. Denny via All-commits all-commits at lists.llvm.org
Wed Sep 4 15:51:11 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7c4eb60c9509c3a750961eac2dbcaad369d911f2
      https://github.com/llvm/llvm-project/commit/7c4eb60c9509c3a750961eac2dbcaad369d911f2
  Author: Joel E. Denny <jdenny.ornl at gmail.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M clang/lib/Driver/ToolChain.cpp

  Log Message:
  -----------
  [Clang] Fix CLANG_TOOLCHAIN_PROGRAM_TIMEOUT logic

PR #102521, which landed as 1ea0865dd6fa, implemented
`CLANG_TOOLCHAIN_PROGRAM_TIMEOUT`, but the logic is obviously wrong.
If the user-specified value is negative, it should become zero to mean
infinite.  Otherwise, it should be left as is.  Thus, use `std::max`
not `std::min`.  This obvious fixup doesn't seem worth another pull
request.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list