[all-commits] [llvm/llvm-project] de37da: [MachineOutliner] Preserve instruction bundles (#1...

[Simon Tatham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: de37da8e37c4c9042563e186068adca98bf59e07
      https://github.com/llvm/llvm-project/commit/de37da8e37c4c9042563e186068adca98bf59e07
  Author: Simon Tatham <simon.tatham at arm.com>
  Date:   2024-09-04 (Wed, 04 Sep 2024)

  Changed paths:
    M llvm/lib/CodeGen/MachineOutliner.cpp
    A llvm/test/CodeGen/AArch64/machine-outliner-bundle.mir

  Log Message:
  -----------
  [MachineOutliner] Preserve instruction bundles (#106402)

When the machine outliner copies instructions from a source function
into an outlined function, it was doing it using `CloneMachineInstr`,
which is documented as not preserving the interior of any instruction
bundle. So outlining code that includes an instruction bundle would
fail, because in the outlined version, the bundle would be empty, so
instructions would go missing in the move.

This occurs when any bundled instruction appears in the outlined code,
so there was no need to construct an unusual test case: I've just copied
a function from the existing `stp-opt-with-renaming.mir`, which happens
to contain an SVE instruction bundle. Including two identical copies of
that function makes the outliner merge them, and then we check that it
didn't destroy the interior of the bundle in the process.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications