[all-commits] [llvm/llvm-project] b076f6: [lldb] Remove limit on max memory read size (#105765)

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b076f6640e3c2781410588f4a8e4ccfeed8eb606
      https://github.com/llvm/llvm-project/commit/b076f6640e3c2781410588f4a8e4ccfeed8eb606
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M lldb/source/Target/TargetProperties.td
    M lldb/test/API/functionalities/memory/big-read/TestMemoryReadMaximumSize.py

  Log Message:
  -----------
  [lldb] Remove limit on max memory read size (#105765)

`memory read` will return an error if you try to read more than 1k bytes
in a single command, instructing you to set
`target.max-memory-read-size` or use `--force` if you intended to read
more than that. This is a safeguard for a command where people are being
explicit about how much memory they would like lldb to read (either to
display, or save to a file) and is an annoyance every time you need to
read more than a small amount. If someone confuses the --count argument
with the start address, lldb may begin dumping gigabytes of data but I'd
rather that behavior than requiring everyone to special-case their way
around a common use case.

I don't want to remove the setting because many people have added (much
larger) default max read sizes to their ~/.lldbinit files after hitting
this behavior. Another option would be to stop reading/using the value
in Target.cpp, but I see no harm in leaving the setting if someone
really does prefer to have a small cap on their memory read size.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications