[all-commits] [llvm/llvm-project] 334d12: [HLSL] Adjust resource binding diagnostic flags co...

[Helena Kotas via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 334d1238aafa8ca017d433caaf8f6e00f2622111
      https://github.com/llvm/llvm-project/commit/334d1238aafa8ca017d433caaf8f6e00f2622111
  Author: Helena Kotas <hekotas at microsoft.com>
  Date:   2024-09-03 (Tue, 03 Sep 2024)

  Changed paths:
    M clang/lib/Sema/SemaHLSL.cpp
    M clang/test/SemaHLSL/resource_binding_attr_error_udt.hlsl

  Log Message:
  -----------
  [HLSL] Adjust resource binding diagnostic flags code (#106657)

Adjust register binding diagnostic flags code in a couple of ways:
- Store the resource class in the Flags struct to avoid duplicated
scanning for HLSLResourceClassAttribute
- Avoid unnecessary indirection when converting resource class to
register type
- Remove recursion and reduce duplicated code

Also fixes a case where struct with an array was incorrectly diagnosed
unfit for `c` register binding.

This will also simplify work that is needed to be done in this area for
llvm/llvm-project#104861.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications