[all-commits] [llvm/llvm-project] 3766ba: [mlir][python] Fix how the mlir variadic Python ac...

[Kasper Nielsen via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3766ba44a8945681f4c52acb0331efcff66ef7b1
      https://github.com/llvm/llvm-project/commit/3766ba44a8945681f4c52acb0331efcff66ef7b1
  Author: Kasper Nielsen <kasper0406 at gmail.com>
  Date:   2024-08-31 (Sat, 31 Aug 2024)

  Changed paths:
    M mlir/python/mlir/dialects/_ods_common.py
    M mlir/test/mlir-tblgen/op-python-bindings.td
    M mlir/test/python/dialects/ods_helpers.py
    M mlir/test/python/dialects/python_test.py
    M mlir/test/python/python_test_ops.td
    M mlir/tools/mlir-tblgen/OpPythonBindingGen.cpp

  Log Message:
  -----------
  [mlir][python] Fix how the mlir variadic Python accessor `_ods_equally_sized_accessor` is used (#101132) (#106003)

As reported in https://github.com/llvm/llvm-project/issues/101132, this
fixes two bugs:

1. When accessing variadic operands inside an operation, it must be
accessed as `self.operation.operands` instead of `operation.operands`
2. The implementation of the `equally_sized_accessor` function is doing
wrong arithmetics when calculating the resulting index and group sizes.

I have added a test for the `equally_sized_accessor` function, which did
not have a test previously.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications