[all-commits] [llvm/llvm-project] 18e550: [mlir][polly][llvm-lit] Fixed logic for turning on...

[Connie Zhu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 18e55052d6c7da765bbec311b1b6ac9590a2bfa3
      https://github.com/llvm/llvm-project/commit/18e55052d6c7da765bbec311b1b6ac9590a2bfa3
  Author: Connie Zhu <60797237+connieyzhu at users.noreply.github.com>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    M mlir/test/lit.cfg.py
    M polly/test/UnitIsl/lit.cfg
    M polly/test/lit.cfg

  Log Message:
  -----------
  [mlir][polly][llvm-lit] Fixed logic for turning on external shell in lit (#106458)

For both mlir and polly, the lit internal shell is the default shell for
running lit tests. However, if the user wanted to switch back to the
external shell by setting `LIT_USE_INTERNAL_SHELL=0`, the `not` used in
the body of the `if` conditional changes `use_lit_shell` to be True
instead of the intended False. Removing `not` allows for this lit config
to work as intended.

Fixes https://github.com/llvm/llvm-project/issues/106459.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications