[all-commits] [llvm/llvm-project] 178392: [llvm-lit] Print environment variables when using ...

[Harini0924 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 178392454e076624674b4a7ddf3fc8bda2e94f0e
      https://github.com/llvm/llvm-project/commit/178392454e076624674b4a7ddf3fc8bda2e94f0e
  Author: Harini0924 <harinidonthula at google.com>
  Date:   2024-08-29 (Thu, 29 Aug 2024)

  Changed paths:
    M llvm/utils/lit/lit/TestRunner.py
    A llvm/utils/lit/tests/Inputs/shtest-env-negative/env-calls-cd.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-negative/env-calls-colon.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-negative/env-calls-echo.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-negative/env-calls-export.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-negative/env-calls-mkdir.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-negative/env-calls-not-builtin.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-negative/env-calls-rm.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-negative/lit.cfg
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/env-args-last-is-assign.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/env-args-last-is-u-arg.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/env-args-last-is-u.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/env-args-nested-none.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/env-calls-env.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/env-no-subcommand.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/env-u.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/env.txt
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/lit.cfg
    A llvm/utils/lit/tests/Inputs/shtest-env-positive/mixed.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-args-last-is-assign.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-args-last-is-u-arg.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-args-last-is-u.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-args-nested-none.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-args-none.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-calls-cd.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-calls-colon.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-calls-echo.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-calls-env.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-calls-export.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-calls-mkdir.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-calls-not-builtin.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-calls-rm.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env-u.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/env.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/lit.cfg
    R llvm/utils/lit/tests/Inputs/shtest-env/mixed.txt
    R llvm/utils/lit/tests/Inputs/shtest-env/print_environment.py
    A llvm/utils/lit/tests/shtest-env-negative.py
    A llvm/utils/lit/tests/shtest-env-positive.py
    R llvm/utils/lit/tests/shtest-env.py

  Log Message:
  -----------
  [llvm-lit] Print environment variables when using env without subcommand (#98414)

This patch addresses an issue with lit's internal shell when env is
without any arguments, it fails with exit code 127 because `env`
requires a subcommand. This patch addresses the issue by encoding the
command to properly return environment variables even when no arguments
are provided.

The error occurred when running the command 
` LIT_USE_INTERNAL_SHELL=1 ninja check-llvm`.

fixes: #102383
This is part of the test cleanups proposed in the RFC: [[RFC] Enabling
the Lit Internal Shell by
Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications