[all-commits] [llvm/llvm-project] 555294: DAG: Check if is_fpclass is custom, instead of isL...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/dag-check-is-legal-or-is-custom-is-fpclass
  Home:   https://github.com/llvm/llvm-project
  Commit: 555294659a4f07452fbcfcfbe89d6e15b633057d
      https://github.com/llvm/llvm-project/commit/555294659a4f07452fbcfcfbe89d6e15b633057d
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-08-29 (Thu, 29 Aug 2024)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/test/CodeGen/AMDGPU/fract-match.ll
    M llvm/test/CodeGen/AMDGPU/llvm.is.fpclass.f16.ll
    M llvm/test/CodeGen/PowerPC/is_fpclass.ll

  Log Message:
  -----------
  DAG: Check if is_fpclass is custom, instead of isLegalOrCustom

For some reason, isOperationLegalOrCustom is not the same as
isOperationLegal || isOperationCustom. Unfortunately, it checks
if the type is legal which makes it uesless for custom lowering
on non-legal types (which is always ppcf128).

Really the DAG builder shouldn't be going to expand this in the
builder, it makes it difficult to work with. It's only here to work
around the DAG requiring legal integer types the same size as
the FP type after type legalization.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications