[all-commits] [llvm/llvm-project] 37792b: [MLIR][Flang][OpenMP] Remove omp.parallel from loo...

[Sergio Afonso via All-commits]

  Branch: refs/heads/users/skatrak/dpd-01-parallel-wrapper
  Home:   https://github.com/llvm/llvm-project
  Commit: 37792b4ddec46beb33bdc400433782b42f310217
      https://github.com/llvm/llvm-project/commit/37792b4ddec46beb33bdc400433782b42f310217
  Author: Sergio Afonso <safonsof at amd.com>
  Date:   2024-08-29 (Thu, 29 Aug 2024)

  Changed paths:
    M flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/test/Dialect/OpenMP/invalid.mlir
    M mlir/test/Dialect/OpenMP/ops.mlir

  Log Message:
  -----------
  [MLIR][Flang][OpenMP] Remove omp.parallel from loop wrapper ops

This patch updates the `omp.parallel` operation according to the results of
the discussion in [this RFC](https://discourse.llvm.org/t/rfc-disambiguation-between-loop-and-block-associated-omp-parallelop/79972).
It is removed from the set of loop wrapper operations, changing the expected
MLIR representation for composite `distribute parallel do/for` into the
following:

```mlir
omp.parallel {
  ...
  omp.distribute {
    omp.wsloop {
      omp.loop_nest ... { ... }
      omp.terminator
    }
    omp.terminator
  }
  ...
  omp.terminator
}
```

MLIR verifiers for operations impacted by this representation change are
updated, as well as related tests. The `LoopWrapperInterface` is also updated,
since it's no longer representing an optional "role" of an operation but a
mandatory set of restrictions instead.


  Commit: cbfb06925563eea2a61966327e6cb2bd68ea8f64
      https://github.com/llvm/llvm-project/commit/cbfb06925563eea2a61966327e6cb2bd68ea8f64
  Author: Sergio Afonso <safonsof at amd.com>
  Date:   2024-08-29 (Thu, 29 Aug 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/test/Dialect/OpenMP/invalid.mlir

  Log Message:
  -----------
  Address review comments


Compare: https://github.com/llvm/llvm-project/compare/678a1a387721...cbfb06925563

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications