[all-commits] [llvm/llvm-project] 1bde8e: [AMDGPU] Don't realign already allocated LDS. Poin...

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Wed Aug 28 10:31:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1bde8e0b80860743fcd55da28f0ba9acb7a26a9c
      https://github.com/llvm/llvm-project/commit/1bde8e0b80860743fcd55da28f0ba9acb7a26a9c
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
    A llvm/test/CodeGen/AMDGPU/lds-no-realign-allocated-variables.ll

  Log Message:
  -----------
  [AMDGPU] Don't realign already allocated LDS. Point fix for 106412 (#106421)

Fixes 106412. The logic that skips the pass on already-lowered variables
doesn't cover the path that increases alignment of variables. If a
variable is allocated at 24 and then given 16 byte alignment, the
backend notices and fatal-errors on the inconsistency.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list